[LLDB] Fix logically dead code

[kwk]

Summary

The indicated dead code may have performed some action; that action will never occur.

In lldb_private::LoadedModuleInfoList::LoadedModuleInfo::operator ==(lldb_private::LoadedModuleInfoList::LoadedModuleInfo const &): Code can never be reached because of a logical contradiction (CWE-561)

Coverity Scan: https://scan3.coverity.com/reports.htm#v39507/p12195/fileInstanceId=27614986&defectInstanceId=8037484&mergedDefectId=221581

CID 221581

[jankratochvil]

Personally I would check GIT history for some reasons it was written this way.

[jankratochvil]

FYI the link does not work for me: https://scan3.coverity.com/reports.htm#v39507/p12195/fileInstanceId=27614986&defectInstanceId=8037484&mergedDefectId=221581

[kwk]

@jankratochvil the file only has two revisions: https://github.com/llvm/llvm-project/commits/b9c1b51e45b845debb76d8658edabca70ca56079/lldb/include/lldb/Core/LoadedModuleInfoList.h

[jankratochvil]

In D67915#1679030, @kwk wrote:

@jankratochvil the file only has two revisions: https://github.com/llvm/llvm-project/commits/b9c1b51e45b845debb76d8658edabca70ca56079/lldb/include/lldb/Core/LoadedModuleInfoList.h

I expected some archeology like: D16004 added operator==() where e_num was already a constant. e_num was added in D9471 and it was also a constant there.
So yes, the fix is OK.

lldb/include/lldb/Core/LoadedModuleInfoList.h

public:
     }
 
     bool has_info(e_data_point datum) const {
       assert(datum < e_num);
       return m_has[datum];
     }
 
     bool operator==(LoadedModuleInfo const &rhs) const {
-      if (e_num != rhs.e_num)
-        return false;
-
       for (size_t i = 0; i < e_num; ++i) {
         if (m_has[i] != rhs.m_has[i])
           return false;
       }
 
       return (m_base == rhs.m_base) && (m_link_map == rhs.m_link_map) &&
              (m_dynamic == rhs.m_dynamic) && (m_name == rhs.m_name);
     }