Page MenuHomePhabricator

[clang-format] NFC clang-format the clang-format unit tests
ClosedPublic

Authored by MyDeveloperDay on Sep 22 2019, 5:09 AM.

Details

Summary

It is annoying that the clang-format tests aren't themselves clang-formatted, if you use a format on save option in VS or vim this file gets massively changed then you have to git difftool all the other changes back out, which is risky.

I know people don't like mass clang-format changes but sometimes it becomes unmanageable to not. There are no other changes here other than just the reformat.

clang-format tests all pass.

[==========] 691 tests from 21 test cases ran. (55990 ms total)
[  PASSED  ] 691 tests.

Diff Detail

Repository
rL LLVM

Event Timeline

MyDeveloperDay created this revision.Sep 22 2019, 5:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 22 2019, 5:09 AM

wrong patch file

I suppose the .clang-format file you used only had BasedOnStyle: LLVM in it. Did you run clang-format the second time to ensure that the formatted file was stable?

I suppose the .clang-format file you used only had BasedOnStyle: LLVM in it. Did you run clang-format the second time to ensure that the formatted file was stable?

it used the .clang-format file from the llvm tree and yes subsequent clang-formats yield no other changes

owenpan accepted this revision.Sep 23 2019, 7:19 AM

Thanks!

This revision is now accepted and ready to land.Sep 23 2019, 7:19 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 23 2019, 11:34 PM