- User Since
- Jan 31 2019, 4:26 PM (200 w, 5 d)
Jun 14 2021
A crash (https://bugs.llvm.org/show_bug.cgi?id=50663) in 12.0.1 is fixed by your changes here when merged to the 12 branch, I'm not sure if this needs to be backported to 12 I guess it might depend on if we think it's critical enough or if there will more 12 release candidates before 13 @timwoj any thoughts?
Mar 4 2021
Rebase onto master again
Mar 1 2021
Feb 28 2021
Feb 10 2021
Rebased on main
Feb 9 2021
Added release note entry
Jan 29 2021
https://bugs.llvm.org/show_bug.cgi?id=48668 already exists as a bug report linked to this review. I'm not sure "the Zeek project would like to start using this" is a good enough reason to block an LLVM release though. I'm fairly certain there aren't a whole lot of people in the world using Whitesmiths. That said, there's already at least one clang-format bug in the release-blocker list.
Jan 28 2021
No problem, sorry it took a bit of back-and-forth there. Is there any way this can sneak into 12.0?
Jan 27 2021
- Make LineLevel an enum class
- Combine multiple duplicate checks into a named variable
- Minor formatting fixes
Jan 25 2021
Restored lost single-nesting namespace test
Jan 20 2021
Add tests for Whitesmiths with all of the NamespaceIndentation options
Jan 19 2021
Fixing diff to look at the right commit
Updates from review:
- Fixed handling of IndentCaseLabels
- Fixed indentation of namespace braces
- Replaced bool argument to addUnwrappedLine with an enum
Jan 14 2021
Jan 13 2021
This fixes https://bugs.llvm.org/show_bug.cgi?id=48569, amongst other things.
Jan 12 2021
Jan 19 2020
I know that 10.0 was branch recently. Any chance this can make it over?
Jan 15 2020
Nov 19 2019
Thanks for the consideration on committer access, but I'm going to have to pass for the time being.
Oct 16 2019
Oct 14 2019
Changed option name to SpacesInConditionalStatement, added isKeywordWithCondition method, added some extra tests
Oct 2 2019
Sep 21 2019
I don't have push access for master. Can someone merge this?
Sep 17 2019
Marked failing tests as FIXME
Sep 16 2019
Jun 11 2019
I updated this patch to remove all of the code from ContinuationIndenter and to use the newer BraceWrapping style option instead of setting each one individually in UnwrappedLineParser.