Page MenuHomePhabricator

[CodeView] Add pragma push/pop_macro for ARM64_FPSR to enum header
ClosedPublic

Authored by mstorsjo on Sep 20 2019, 1:53 PM.

Details

Summary

This fixes (one aspect of) compilation of LLDB with MSVC for ARM64.

LLDB source files include intrin.h, and the MSVC intrin.h transitively includes arm64intr.h, which has an ARM64_FPSR define, which clashes with the enum declaration.

Diff Detail

Repository
rL LLVM

Event Timeline

mstorsjo created this revision.Sep 20 2019, 1:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 20 2019, 1:53 PM

Thanks for catching this. Could the #pragma push and #undef be moved to the line right before CV_REGISTER(ARM64_FPSR, 220). An inline commend will also be great.

Thanks for catching this. Could the #pragma push and #undef be moved to the line right before CV_REGISTER(ARM64_FPSR, 220).

I guess I could, but the file has a predecent for this kind of placement (for CR0) as well.

An inline commend will also be great.

Sure, I'll add that.

mstorsjo updated this revision to Diff 221115.Sep 20 2019, 2:25 PM

Added a comment.

TomTan accepted this revision.Sep 20 2019, 2:37 PM

LGTM.

This revision is now accepted and ready to land.Sep 20 2019, 2:37 PM
This revision was automatically updated to reflect the committed changes.