This is an archive of the discontinued LLVM Phabricator instance.

dotest.py: bugfix: test filters with -f do not work on Python3
ClosedPublic

Authored by lawrence_danna on Sep 19 2019, 9:20 PM.

Details

Summary

dotest -f does not work on Python3.

The name types.UnboundMethodType was an alias for types.MethodType in
2.7, but it does not exist in python3. MethodType works in both.

Also the actual type returned from SomeClass.some_method in python3
will be types.Function, not MethodType.

Diff Detail

Repository
rL LLVM

Event Timeline

lawrence_danna created this revision.Sep 19 2019, 9:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 19 2019, 9:20 PM
JDevlieghere accepted this revision.Sep 20 2019, 9:34 AM

I would prefer to update the unittest2 dependency instead, but I tried doing so and it appears to be less straightforward than I'd hoped. I have added it to my todo-list, but this is fine in the meantime.

This revision is now accepted and ready to land.Sep 20 2019, 9:34 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 20 2019, 4:41 PM