This is an archive of the discontinued LLVM Phabricator instance.

Differential D67702

[lldb] Fix a test assertion after r372192
ClosedPublic

Authored by krasimir on Sep 18 2019, 5:24 AM.

Details

Reviewers
bkramer
Commits
rG98c0dc39de24: [lldb] Fix a test assertion after r372192
rL372221: [lldb] Fix a test assertion after r372192
rLLDB372221: [lldb] Fix a test assertion after r372192
Summary

The CHECK: frame:py: None seems to have been a typo, causing build bot failures:

# CHECK: frame:py: None

         ^

<stdin>:1:1: note: scanning from here

(lldb) command source -s 0 'E:/build_slave/lldb-x64-windows-ninja/build/tools/lldb\lit\lit-lldb-init'

^

<stdin>:23:1: note: possible intended match here

frame:py: No value

^

This update fixes the build bots.

--

Diff Detail

Repository
rL LLVM

Event Timeline

krasimir created this revision.Sep 18 2019, 5:24 AM
Harbormaster completed remote builds in B38250: Diff 220650.Sep 18 2019, 5:25 AM
krasimir added a reviewer: bkramer.Sep 18 2019, 5:25 AM
bkramer accepted this revision.Sep 18 2019, 5:34 AM

Rubber stamp'd

This revision is now accepted and ready to land.Sep 18 2019, 5:34 AM
Closed by commit rL372221: [lldb] Fix a test assertion after r372192 (authored by krasimir). · Explain WhySep 18 2019, 5:40 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 18 2019, 5:40 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
labath added a subscriber: labath.Sep 18 2019, 5:57 AM

Unfortunately, that wasn't a typo, but an actual bug. r372222 should have a better fix for that (along with a description of the problem, if you're interested)

Revision Contents

PathSize
lldb/
trunk/
lit/
Commands/
2 lines

Diff 220652

lldb/trunk/lit/Commands/command-script-import.test

# RUN: echo 'b main' > %t.in # RUN: echo 'b main' > %t.in
# RUN: echo 'run' >> %t.in # RUN: echo 'run' >> %t.in
# RUN: echo 'command script import %S/Inputs/frame.py' >> %t.in # RUN: echo 'command script import %S/Inputs/frame.py' >> %t.in
# RUN: %clang -g -O0 %S/Inputs/main.c -o %t.out # RUN: %clang -g -O0 %S/Inputs/main.c -o %t.out
# RUN: %lldb -b -s %t.in -o 'script print("script: {}").format(lldb.frame)' %t.out | FileCheck %s # RUN: %lldb -b -s %t.in -o 'script print("script: {}").format(lldb.frame)' %t.out | FileCheck %s
# Make sure that we don't have access to lldb.frame from the Python script. # Make sure that we don't have access to lldb.frame from the Python script.
# CHECK: frame:py: None # CHECK: frame:py: No value
# Make sure that we do have access to lldb.frame from the script command. # Make sure that we do have access to lldb.frame from the script command.
# CHECK: script: frame #0 # CHECK: script: frame #0