Page MenuHomePhabricator

[MemorySSA] Fix phi insertion when inserting a def.
ClosedPublic

Authored by asbirlea on Sep 16 2019, 3:11 PM.

Details

Summary

When inserting a Def, the current algorithm is walking edges backward
and inserting new Phis where needed. There may be additional Phis needed
in the IDF of the newly inserted Def and Phis.
Adding Phis in the IDF of the Def was added ina previous patch, but we
may also need other Phis in the IDF of the newly added Phis.

Resolves PR43320.

Diff Detail

Repository
rL LLVM

Event Timeline

asbirlea created this revision.Sep 16 2019, 3:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 16 2019, 3:11 PM
asbirlea edited the summary of this revision. (Show Details)Sep 16 2019, 3:17 PM

thanks!

lib/Analysis/MemorySSAUpdater.cpp
343 ↗(On Diff #220399)

will the compiler accept a const here? (and above)

This revision is now accepted and ready to land.Sep 16 2019, 8:50 PM
asbirlea updated this revision to Diff 220515.Sep 17 2019, 9:02 AM
asbirlea marked an inline comment as done.

Added const.

This revision was automatically updated to reflect the committed changes.