Page MenuHomePhabricator

Add dependency from Orc to Passes
ClosedPublic

Authored by sanjoy on Sep 11 2019, 7:48 PM.

Details

Summary

Orc uses registerFunctionAnalyses that's defined in Passes.

Diff Detail

Repository
rL LLVM

Event Timeline

sanjoy created this revision.Sep 11 2019, 7:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 11 2019, 7:48 PM

I vaguely recall @lhames had some opinions on this layeering, might have another fix in mind.

lhames accepted this revision.Sep 12 2019, 7:55 AM

Yep — eventually I want to break out the parts of ORC that rely on IR/Passes. This is the right thing to do for now though. Thanks Sanjoy!

This revision is now accepted and ready to land.Sep 12 2019, 7:55 AM
This revision was automatically updated to reflect the committed changes.