This is an archive of the discontinued LLVM Phabricator instance.

Start porting ivfsoverlay tests to Windows
ClosedPublic

Authored by rnk on Sep 11 2019, 11:38 AM.

Details

Summary

Part of PR43272, the changes are:

  1. Use @ as the sed pattern delimiter instead of : so that the drive

letter in lit substitutions isn't an issue.

  1. Use the %/t and %/S substitutions to get paths with forward slashes

to work around string quoting issues in the yaml file.

  1. Replace REQUIRES:shell with XFAIL:windows. These tests should pass on

Windows, but do not for reasons that are not yet understood. We would
like to know if they pass unexpectedly.

I was able to remove the XFAILs from two tests, since they already pass
with my sed fix:

clang/test/VFS/module_missing_vfs.m
clang/test/VFS/test_nonmodular.c

Diff Detail

Repository
rL LLVM

Event Timeline

rnk created this revision.Sep 11 2019, 11:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 11 2019, 11:38 AM
Herald added a subscriber: arphaman. · View Herald Transcript
This revision is now accepted and ready to land.Sep 11 2019, 1:15 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 11 2019, 1:55 PM