Page MenuHomePhabricator

Make SwitchInstProfUpdateWrapper strict permanently
ClosedPublic

Authored by yrouban on Sep 11 2019, 3:43 AM.

Details

Summary

We have been using -switch-inst-prof-update-wrapper-strict set to true by default for some time.
It is time to remove the safety stuff and make SwitchInstProfUpdateWrapper intolerant to inconsistencies in !prof branch_weights metadata of SwitchInst.
This patch gets rid of the Invalid state of SwitchInstProfUpdateWrapper and the option -switch-inst-prof-update-wrapper-strict.
So there is only two states: changed and unchanged.

Diff Detail

Repository
rL LLVM

Event Timeline

yrouban created this revision.Sep 11 2019, 3:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 11 2019, 3:43 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
davidxl accepted this revision.Sep 11 2019, 8:41 AM

lgtm

This revision is now accepted and ready to land.Sep 11 2019, 8:41 AM
This revision was automatically updated to reflect the committed changes.