This is an archive of the discontinued LLVM Phabricator instance.

Differential D67391

Fix the "git modified" issue on the preserve-comments-crlf.s.
ClosedPublic

Authored by hokein on Sep 10 2019, 3:28 AM.

Details

Reviewers
gribozavr
Commits
rG973bd3e974bc: Fix the "git modified" issue on the preserve-comments-crlf.s.
rL371513: Fix the "git modified" issue on the preserve-comments-crlf.s.
Summary

rL371473 corrected the line ending (to crlf) in preserve-comments-crlf.s, but it causes a wired issue on git
repository (I ran git pull today, it showed a local change of that file even I did not change anything).

Diff Detail

Event Timeline

hokein created this revision.Sep 10 2019, 3:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 10 2019, 3:28 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B37950: Diff 219507.Sep 10 2019, 3:28 AM
hokein edited the summary of this revision. (Show Details)Sep 10 2019, 3:33 AM
hokein updated this revision to Diff 219522.Sep 10 2019, 4:54 AM

Update the patch.

Harbormaster completed remote builds in B37952: Diff 219522.Sep 10 2019, 4:55 AM
hokein retitled this revision from Copy llvm .gitattributes to the monorepository. to Fix the "git modified" issue on the preserve-comments-crlf.s..Sep 10 2019, 4:56 AM
hokein edited the summary of this revision. (Show Details)
gribozavr accepted this revision.Sep 10 2019, 5:02 AM
This revision is now accepted and ready to land.Sep 10 2019, 5:02 AM
Closed by commit rL371513: Fix the "git modified" issue on the preserve-comments-crlf.s. (authored by hokein). · Explain WhySep 10 2019, 5:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
6 lines

Diff 219522

llvm/.gitattributes

# binary files # binary files
test/Object/Inputs/*.a-* binary test/Object/Inputs/*.a-* binary
test/tools/dsymutil/Inputs/*.o binary test/tools/dsymutil/Inputs/*.o binary
test/tools/dsymutil/Inputs/*.a binary test/tools/dsymutil/Inputs/*.a binary
test/tools/dsymutil/Inputs/*.i386 binary test/tools/dsymutil/Inputs/*.i386 binary
test/tools/dsymutil/Inputs/*.x86_64 binary test/tools/dsymutil/Inputs/*.x86_64 binary
test/tools/dsymutil/Inputs/*.armv7m binary test/tools/dsymutil/Inputs/*.armv7m binary
test/tools/dsymutil/Inputs/*.dylib binary test/tools/dsymutil/Inputs/*.dylib binary
test/tools/llvm-ar/Inputs/*.lib binary test/tools/llvm-ar/Inputs/*.lib binary
test/tools/llvm-objdump/Inputs/*.a binary test/tools/llvm-objdump/Inputs/*.a binary
test/tools/llvm-rc/Inputs/* binary test/tools/llvm-rc/Inputs/* binary
test/tools/llvm-strings/Inputs/numbers binary test/tools/llvm-strings/Inputs/numbers binary
test/MC/AsmParser/incbin_abcd binary test/MC/AsmParser/incbin_abcd binary
test/YAMLParser/spec-09-02.test binary test/YAMLParser/spec-09-02.test binary
# Windows line ending test # This file must have CRLF line endings, therefore git should treat it as
test/MC/AsmParser/preserve-comments-crlf.s text eol=crlf # binary and not autoconvert line endings (for example, when core.autocrlf is
# on).
test/MC/AsmParser/preserve-comments-crlf.s binary