This is an archive of the discontinued LLVM Phabricator instance.

Differential D67349

[Inliner][NFC] Make test less brittle.
ClosedPublic

Authored by courbet on Sep 9 2019, 5:38 AM.

Details

Reviewers
RKSimon
qcolombet
Commits
rG388b9794b619: [Inliner][NFC] Make test less brittle.
rL371397: [Inliner][NFC] Make test less brittle.
Summary

This tests inlining size thresholds, but relies on the output of running
the full O2 pipeline, making it brittle against changes in unrelated
passes.

Only run the inlining pass and set thresholds on the test RUN line
instead.

Found while investigating D60318.

Diff Detail

Event Timeline

courbet created this revision.Sep 9 2019, 5:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 9 2019, 5:38 AM
Harbormaster completed remote builds in B37908: Diff 219326.Sep 9 2019, 5:40 AM
RKSimon accepted this revision.Sep 9 2019, 6:03 AM

LGTM

This revision is now accepted and ready to land.Sep 9 2019, 6:03 AM
courbet added a comment.Sep 9 2019, 6:06 AM

Thanks.

Closed by commit rL371397: [Inliner][NFC] Make test less brittle. (authored by courbet). · Explain WhySep 9 2019, 6:07 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
test/
Transforms/
Inline/
2 lines

Diff 219326

llvm/test/Transforms/Inline/inline_minisize.ll

; RUN: opt -O2 -S < %s | FileCheck %s ; RUN: opt -inline -inline-threshold=225 -inlinehint-threshold=360 -S < %s | FileCheck %s
@data = common global i32* null, align 8 @data = common global i32* null, align 8
define i32 @fct1(i32 %a) nounwind uwtable ssp { define i32 @fct1(i32 %a) nounwind uwtable ssp {
entry: entry:
%a.addr = alloca i32, align 4 %a.addr = alloca i32, align 4
%res = alloca i32, align 4 %res = alloca i32, align 4
%i = alloca i32, align 4 %i = alloca i32, align 4
▲ Show 20 Lines • Show All 223 Lines • Show Last 20 Lines