Page MenuHomePhabricator

Fix dlopen-mixed-c-cxx test case when libstdc++ is not available
AbandonedPublic

Authored by serge-sans-paille on Sep 7 2019, 8:56 AM.

Details

Reviewers
Hahnfeld
Summary

compiler-rt/test/asan/TestCases/Linux/dlopen-mixed-c-cxx.c test case requires libstdc++ to be linked and available. Make this requirement explicit.

Diff Detail

Event Timeline

Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptSep 7 2019, 8:56 AM
Herald added subscribers: llvm-commits, Restricted Project, srhines. · View Herald Transcript
serge-sans-paille abandoned this revision.Sep 7 2019, 9:01 AM

For the record, I don't think this would have worked: I do have libstdc++ available on my system (I just choose SANITIZER_CXX_ABI=libcxxabi for other reasons) and passing -stdlib=libstdc++ when building the test doesn't help as I've already said in D67298. Moreover, there's nothing in the test that requires libstdc++, it just happens to pass due to many chained implications, and restricting a test without understanding the root cause is probably no good idea.