Page MenuHomePhabricator

[llvm-ifs] Fixing hardcoding of PlatformKind for TBD generation
ClosedPublic

Authored by plotfi on Sep 5 2019, 11:14 PM.

Details

Summary

@cishida noticed I had hardcoded PlatformKind in my TBD generation in my first commit of llvm-ifs. This is a differential to get that rectified.

Any pointers on what the proper triple for BridgeOS should be would be helpful.

Diff Detail

Repository
rL LLVM

Event Timeline

plotfi created this revision.Sep 5 2019, 11:14 PM
Herald added a project: Restricted Project. ยท View Herald TranscriptSep 5 2019, 11:14 PM
Herald added a subscriber: llvm-commits. ยท View Herald Transcript

bridgeOS hasn't been added to llvm triple yet, so it's fine to exclude it for now.
also I have a patch I'm adding very soon that takes in llvm::triple and does the arch/platform mapping so you won't need to. I'll update this file when it comes out.

cishida accepted this revision.Sep 6 2019, 8:11 AM

LGTM

This revision is now accepted and ready to land.Sep 6 2019, 8:11 AM

bridgeOS hasn't been added to llvm triple yet, so it's fine to exclude it for now.
also I have a patch I'm adding very soon that takes in llvm::triple and does the arch/platform mapping so you won't need to. I'll update this file when it comes out.

Awesome. Thanks @cishida ๐Ÿ™

This revision was automatically updated to reflect the committed changes.