Page MenuHomePhabricator

Remove the additional constant which requires an extra register for statepoint lowering.
AcceptedPublic

Authored by linzj on Sep 4 2019, 12:46 AM.

Details

Summary

The newly-created constant zero will need an extra register to hold it
in the current statepoint lowering implementation. Remove it if there exists
one.

Event Timeline

linzj created this revision.Sep 4 2019, 12:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 4 2019, 12:46 AM
linzj added a reviewer: arsenm.Sep 4 2019, 6:07 PM
arsenm added inline comments.Sep 4 2019, 6:22 PM
llvm/lib/CodeGen/SelectionDAG/StatepointLowering.cpp
858–860

This loses using the right address space sized pointer

linzj marked an inline comment as done.Sep 4 2019, 6:55 PM
linzj added inline comments.
llvm/lib/CodeGen/SelectionDAG/StatepointLowering.cpp
858–860

Should I just assign ActualCallee with ConstCallee?

linzj marked an inline comment as not done.Sep 4 2019, 6:55 PM
linzj updated this revision to Diff 218829.Sep 4 2019, 7:44 PM

Use undef SDValue instead.

sanjoy removed a reviewer: sanjoy.Sep 7 2019, 9:29 AM
arsenm accepted this revision.Thu, Feb 13, 4:39 PM

LGTM

This revision is now accepted and ready to land.Thu, Feb 13, 4:39 PM