Page MenuHomePhabricator

[dotest] Add @skipIfCursesSupportMissing and annotate the new gui test
ClosedPublic

Authored by labath on Sep 2 2019, 5:25 AM.

Details

Summary

The gui command requires curses support, which can be disabled at
compile time. This patch adds the ability to detect this situation in
the test suite and skip the test accordingly.

Diff Detail

Repository
rL LLVM

Event Timeline

labath created this revision.Sep 2 2019, 5:25 AM
teemperor accepted this revision.Sep 2 2019, 5:34 AM

LGTM, thanks!

This revision is now accepted and ready to land.Sep 2 2019, 5:34 AM
jankratochvil accepted this revision.Sep 2 2019, 5:39 AM
jankratochvil added inline comments.
packages/Python/lldbsuite/test/decorators.py
786 ↗(On Diff #218336)

I find a bit confusing the function returns opposite of key existence but its name does not indicate that. The skipIf could stay in its name.

labath marked an inline comment as done.Sep 2 2019, 5:41 AM
labath added inline comments.
packages/Python/lldbsuite/test/decorators.py
786 ↗(On Diff #218336)

good point, lemme rename that

labath updated this revision to Diff 218345.Sep 2 2019, 5:51 AM

Rename the function to _get_bool_config_skip_if_decorator

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptSep 2 2019, 6:32 AM