Page MenuHomePhabricator

[LV] Tail-folding, runtime scev checks
ClosedPublic

Authored by SjoerdMeijer on Aug 29 2019, 2:39 AM.

Details

Summary

Now that we allow tail-folding, not only when we optimise for size, make
sure we do not run in this assert.

Diff Detail

Repository
rL LLVM

Event Timeline

SjoerdMeijer created this revision.Aug 29 2019, 2:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2019, 2:39 AM
Ayal added inline comments.Aug 29 2019, 3:33 AM
llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
2699 ↗(On Diff #217805)

Error message should be updated as well.

llvm/test/Transforms/LoopVectorize/X86/tail-folding-scevcheck.ll
12 ↗(On Diff #217805)

Better also check instructions, not only labels?

Thanks, comments addressed

Ayal accepted this revision.Sep 3 2019, 12:36 AM
This revision is now accepted and ready to land.Sep 3 2019, 12:36 AM
This revision was automatically updated to reflect the committed changes.