[ScopBuilder]Remove redundant while loop in ScopBuilder::buildDomains

[bin.narwal]

Summary

Hi,
The while loop iterating parent loop in ScopBuilder::buildDomains is unnecessary because either L or LD are later unused, this is a simple patch removing it. Is it OK?

Thanks,
bin

[Meinersbur]

LGMT. L is just unused after that (not "redundant"). Can you correct the summary?

I can commit this for you if you would like me to.

[bin.narwal]

In D66698#1645979, @Meinersbur wrote:

LGMT. L is just unused after that (not "redundant"). Can you correct the summary?

Hmm, but the while loop is redundant, right? I modified the summary mentioning that L/LD are later unused.

I can commit this for you if you would like me to.

Yes, please help commit this for me. Thanks very much.

[Meinersbur]

In D66698#1646819, @bin.narwal wrote:

Hmm, but the while loop is redundant, right?

In my understanding of the word, "redundant" means unnecessarily doing something that has already been done. I'd call the loop "dead".

[bin.narwal]

In D66698#1647652, @Meinersbur wrote:

In D66698#1646819, @bin.narwal wrote:

Hmm, but the while loop is redundant, right?

In my understanding of the word, "redundant" means unnecessarily doing something that has already been done. I'd call the loop "dead".

Right, I adjusted words accordingly.

Thanks,

[Meinersbur]

I adjusted the title as well.

Thank you for your contribution!

lib/Analysis/ScopBuilder.cpp

bool ScopBuilder::buildDomains(
     Region *R, DenseMap<BasicBlock *, isl::set> &InvalidDomainMap) {
   bool IsOnlyNonAffineRegion = scop->isNonAffineSubRegion(R);
   auto *EntryBB = R->getEntry();
   auto *L = IsOnlyNonAffineRegion ? nullptr : LI.getLoopFor(EntryBB);
   int LD = scop->getRelativeLoopDepth(L);
   auto *S =
       isl_set_universe(isl_space_set_alloc(scop->getIslCtx().get(), 0, LD + 1));
 
-  while (LD-- >= 0) {
-    L = L->getParentLoop();
-  }
-
   InvalidDomainMap[EntryBB] = isl::manage(isl_set_empty(isl_set_get_space(S)));
   isl::noexceptions::set Domain = isl::manage(S);
   scop->setDomain(EntryBB, Domain);
 
   if (IsOnlyNonAffineRegion)
     return !containsErrorBlock(R->getNode(), *R, LI, DT);
 
   if (!buildDomainsWithBranchConstraints(R, InvalidDomainMap))