- User Since
- Aug 20 2019, 6:16 AM (12 w, 6 d)
Tue, Nov 12
Mon, Nov 11
Oct 18 2019
Oct 15 2019
That's because the code doesn't model branch instruction (which is terminator) at all right now. If in case terminator instruction must be handled, we would need to handle it as an "ordered" instruction, just like memory access ones.
Fixed as you suggested. Yes please help commit this on behalf of me.
Oct 14 2019
Sep 12 2019
Sorry for delaying. Here is the updated patch as agreed. Also, please help me commit it.
Sep 5 2019
Sep 4 2019
Yes, the order is not guaranteed, and Inst's leader could change during merging, but IIUC, these do not matter.
For the check condition:
if (Prev != Leader)
"Leader" is computed when we try to insert "Inst" into SeenLeaders. Whether leader of the "Leader" changes doesn't have impact on the loop, as long as the first "Prev" in the merging group is actually "Leader". The cons is we may do unnecessary call to unionSets because we only break at the first Prev Inst of merging group.
So looks like we can either compare real leaders of the two Insts, or just compare the two Insts it-selves.
Aug 30 2019
Aug 28 2019
Aug 27 2019
Hmm, but the while loop is redundant, right? I modified the summary mentioning that L/LD are later unused.
I can commit this for you if you would like me to.
Yes, please help commit this for me. Thanks very much.
Hi Michael, thanks for reviewing. I updated the diff according to your comments.
And yes, please help commit this for me.
Aug 26 2019
Aug 23 2019
Aug 22 2019
Thanks very much for reviewing. Here is the updated patch according to your comments.