This is an archive of the discontinued LLVM Phabricator instance.

hwasan: Align n_namesz and n_descsz to 4 when reading notes.
ClosedPublic

Authored by pcc on Aug 23 2019, 4:23 PM.

Details

Summary

There is no requirement for the producer of a note to include the note
alignment in these fields. As a result we can end up missing the HWASAN note
if one of the other notes in the binary has the alignment missing.

Event Timeline

pcc created this revision.Aug 23 2019, 4:23 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 23 2019, 4:24 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
eugenis accepted this revision.Aug 23 2019, 4:26 PM

LGTM

This revision is now accepted and ready to land.Aug 23 2019, 4:26 PM
This revision was automatically updated to reflect the committed changes.