Page MenuHomePhabricator

[lldb] Fix x86 compilation
ClosedPublic

Authored by leonid.mashinskiy on Aug 23 2019, 8:08 AM.

Diff Detail

Repository
rLLDB LLDB

Event Timeline

tatyana-krasnukha added inline comments.
source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_i386.h
9

These macros are also defined when the compilation target is ARM.
I'd use #if defined(__i386__) || defined(_M_IX86) instead.

Updated used guarding macros to cut-off ARM and ARM64 architectures as @tatyana-krasnukha mentioned

tatyana-krasnukha added a comment.EditedAug 26 2019, 6:12 AM

Macros __x86_64__ and _M_X64 are more common than AMD-branded, though there is no functional difference (unless using old versions of the Intel compiler).

A few typos remained after copy-pasting

source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_i386.cpp
279

written?

281

write

leonid.mashinskiy marked 3 inline comments as done.
This revision is now accepted and ready to land.Aug 27 2019, 7:06 AM

@tatyana-krasnukha Can you commit this please because I have no commit access

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 27 2019, 10:34 AM