This is an archive of the discontinued LLVM Phabricator instance.

Differential D66493

[NewPM] Run ubsan-coroutines test under the legacy pass manager only
ClosedPublic

Authored by leonardchan on Aug 20 2019, 1:31 PM.

Details

Reviewers
vsk
modocache
Commits
rGb0a7544ee2e3: [NewPM] Run ubsan-coroutines test under the legacy pass manager only
rL369442: [NewPM] Run ubsan-coroutines test under the legacy pass manager only
rC369442: [NewPM] Run ubsan-coroutines test under the legacy pass manager only
Summary

The passes that lower the llvm.coro.* instrinsics have not yet been ported, so only run under the legacy PM for now.

See https://bugs.llvm.org/show_bug.cgi?id=42867

Diff Detail

Repository
rL LLVM

Event Timeline

leonardchan created this revision.Aug 20 2019, 1:31 PM
Herald added a subscriber: EricWF. · View Herald TranscriptAug 20 2019, 1:31 PM
leonardchan mentioned this in D44672: [CodeGen] Disable UBSan for coroutine functions.Aug 20 2019, 1:32 PM
vsk accepted this revision.Aug 20 2019, 1:41 PM

Thanks, lgtm.

This revision is now accepted and ready to land.Aug 20 2019, 1:41 PM
Closed by commit rL369442: [NewPM] Run ubsan-coroutines test under the legacy pass manager only (authored by leonardchan). · Explain WhyAug 20 2019, 1:55 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 20 2019, 1:55 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
cfe/
trunk/
test/
CodeGenCXX/
4 lines

Diff 216242

cfe/trunk/test/CodeGenCXX/ubsan-coroutines.cpp

// This test merely verifies that emitting the object file does not cause a // This test merely verifies that emitting the object file does not cause a
// crash when the LLVM coroutines passes are run. // crash when the LLVM coroutines passes are run.
// RUN: %clang_cc1 -emit-obj -std=c++2a -fsanitize=null %s -o %t.o // PR42867: Disable this test for the new PM since the passes that lower the
// llvm.coro.* intrinsics have not yet been ported.
// RUN: %clang_cc1 -fno-experimental-new-pass-manager -emit-obj -std=c++2a -fsanitize=null %s -o %t.o
namespace std::experimental { namespace std::experimental {
template <typename R, typename... T> struct coroutine_traits { template <typename R, typename... T> struct coroutine_traits {
using promise_type = typename R::promise_type; using promise_type = typename R::promise_type;
}; };
template <class Promise = void> struct coroutine_handle; template <class Promise = void> struct coroutine_handle;
template <> struct coroutine_handle<void> { template <> struct coroutine_handle<void> {
Show All 38 Lines