Page MenuHomePhabricator

[llvm-extract] Update the help message for group extraction feature
ClosedPublic

Authored by jsji on Aug 19 2019, 2:01 PM.

Details

Summary

https://reviews.llvm.org/D60973 exposed the group extraction feature of
the BlockExtractor to llvm-extract.
However, the help message was not updated, so users might not be able to
know how to use this feature without looking into history/commits.

This patch just update the help message to show how to use this group
extraction feature.

Diff Detail

Repository
rL LLVM

Event Timeline

jsji created this revision.Aug 19 2019, 2:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 19 2019, 2:01 PM

Hi Jinsong,

Good catch.

Comment below.

Cheers,
-Quentin

llvm/tools/llvm-extract/llvm-extract.cpp
78 ↗(On Diff #215978)

I find the use of "group" here confusing.
Maybe we should stick to <function, basic block1[;basic block2...]> like you did in the value_desc.

Maybe also specify that func:bb1;bb2 is not equivalent to func:bb1 func:bb2 (1 function created with bb1 + bb2, vs. two function created; one with bb1, one with bb2).

jsji updated this revision to Diff 216048.Aug 19 2019, 8:00 PM

Agree, how about this?

jsji updated this revision to Diff 216049.Aug 19 2019, 8:04 PM

Add missing '-'.

Harbormaster completed remote builds in B36999: Diff 216049.
qcolombet accepted this revision.Aug 20 2019, 12:42 PM
qcolombet added inline comments.
llvm/tools/llvm-extract/llvm-extract.cpp
84 ↗(On Diff #216049)

I think extract is more appropriate than split.

This revision is now accepted and ready to land.Aug 20 2019, 12:42 PM
jsji updated this revision to Diff 216231.Aug 20 2019, 1:33 PM

Use 'extract' instead of 'split'.

This revision was automatically updated to reflect the committed changes.