Page MenuHomePhabricator

[DWARF] Fix DWARFUnit::getDebugInfoSize() for 64-bit DWARF.
ClosedPublic

Authored by ikudrin on Aug 19 2019, 8:49 AM.

Details

Summary

The calculations in that method were correct only for DWARF32. In cases of DWARF64 they might result in overflow which might lead to a crash, for example, in DWARFUnit::extractDIEsToVector().

Diff Detail

Repository
rL LLVM

Event Timeline

ikudrin created this revision.Aug 19 2019, 8:49 AM
aprantl accepted this revision.Aug 19 2019, 9:04 AM
This revision is now accepted and ready to land.Aug 19 2019, 9:04 AM
This revision was automatically updated to reflect the committed changes.

Hi @aprantl please remember to post a comment along with approval, so that Phab will send an email to the commits list. Thanks!