These can turn up during multiplication legalization. In principle these should also apply to smul_lohi, but I wasn't able to figure out how to produce those.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp | ||
---|---|---|
4292 ↗ | (On Diff #215748) | Do we need a canonicalization of constants to the RHS? |
llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp | ||
---|---|---|
4292 ↗ | (On Diff #215748) | Possibly, but no test case where this would be needed comes to mind. If we start from canonical IR we have constants on the RHS anyway, but even if we start from non-canonical IR, the constant will be moved to the RHS for ISD::MUL, before we get here. Possibly it could happen via UMULO, though in that case we should probably already canonicalize while it is a UMULO. |