Page MenuHomePhabricator

Refactor isPointerOffset (NFC).
ClosedPublic

Authored by eugenis on Aug 15 2019, 4:02 PM.

Details

Summary

Simplify the API using Optional<> and address comments in

https://reviews.llvm.org/D66165

Diff Detail

Repository
rL LLVM

Event Timeline

eugenis created this revision.Aug 15 2019, 4:02 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 15 2019, 4:02 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
vitalybuka accepted this revision.Mon, Aug 19, 1:40 PM
vitalybuka added inline comments.
llvm/include/llvm/Analysis/ValueTracking.h
667 ↗(On Diff #215488)

const Value *Ptr1?

This revision is now accepted and ready to land.Mon, Aug 19, 1:40 PM
eugenis updated this revision to Diff 215979.Mon, Aug 19, 2:04 PM

address comments

eugenis marked an inline comment as done.Mon, Aug 19, 2:05 PM
This revision was automatically updated to reflect the committed changes.