[test/Object] - Move/rewrite 2 more test cases.

[grimar]

Summary

This patch makes a change for test/Object tests responsible
for relocations.

1. 2 tests were moved to llvm-readobj/llvm-objdump folders:

Object/elf-reloc-no-sym.test -> tools/llvm-readobj/elf-reloc-no-sym.test
Object/objdump-reloc-shared.test -> tools/llvm-objdump/relocations-in-nonreloc.test

2. A prerecompiled binary was removed and these tests were refactored.

[MaskRay]

test/tools/llvm-objdump/relocations-in-nonreloc.test

29 ↗

(On Diff #215382)

Nit: non-zero r_offset & r_addend for IRELATIVE will be more realistic. At runtime, image_base + r_addend will be called as a function. r_addend should be non-zero.

60 ↗

(On Diff #215382)

Nit: assemblers do not produce R_X86_64_IRELATIVE (i.e. they should not appear in object files). You can use a different one, e.g. PLT32. (I believe IRELATIVE in .rela.plt is a historical GNU mistake, see D65651)

[jhenderson]

test/tools/llvm-objdump/relocations-in-nonreloc.test

25 ↗

(On Diff #215382)

I don't think SHF_INFO_LINK is needed in any of these inputs.

29 ↗

(On Diff #215382)

I don't think we need this test to be particularly realistic. It just needs to have a relocation in it (I say R_X86_64_NONE to show it's suitably arbitrary), and show whether or not that relocation is printed.

test/tools/llvm-readobj/elf-reloc-no-sym.test

19 ↗

(On Diff #215382)

Entry address isn't significant to this test.

23 ↗

(On Diff #215382)

I don't think SHF_INFO_LINK is needed.

25–27 ↗

(On Diff #215382)

I'd just simplify this. The numbers look like they're significant in some way, when really they can just be arbitrary (e.g. 0x12345678 would be more clearly arbitrary, I think).

[MaskRay]

test/tools/llvm-objdump/relocations-in-nonreloc.test

29 ↗

(On Diff #215382)

R_X86_64_NONE is not arbitrary but it will justify arbitrary r_offset/r_addend (so you can even omit r_addend)

[grimar]

• Addressed review comments.

test/tools/llvm-objdump/relocations-in-nonreloc.test

25 ↗

(On Diff #215382)

Technically SHF_ALLOC or any other flags are also not needed.
I removed them.

29 ↗

(On Diff #215382)

I used R_X86_64_NONE.

[jhenderson]

LGTM.

test/tools/llvm-readobj/elf-reloc-no-sym.test

25 ↗

(On Diff #215541)

Maybe worth making this R_X86_64_NONE too? Doesn't really matter though.

[MaskRay]

test/tools/llvm-readobj/elf-reloc-no-sym.test

25 ↗

(On Diff #215541)

Using different relocation types (not all R_*_NONE) adds some variety..

llvm/test/Object/elf-reloc-no-sym.test

-RUN: llvm-readobj -r %p/Inputs/elf-reloc-no-sym.x86_64 | FileCheck %s
-
-CHECK:      Relocations [
-CHECK-NEXT:   Section (1) .rela.plt {
-CHECK-NEXT:     0x4011D8 R_X86_64_IRELATIVE - 0x400120
-CHECK-NEXT:   }
-CHECK-NEXT: ]

llvm/test/Object/objdump-reloc-shared.test

-RUN: llvm-objdump -r %p/Inputs/elf-reloc-no-sym.x86_64 \
-RUN:              | FileCheck %s
-
-; CHECK: elf-reloc-no-sym.x86_64:       file format ELF64-x86-64
-; CHECK-NOT: {{.}}

llvm/test/tools/llvm-objdump/relocations-in-nonreloc.test

+## Check that objdump doesn't print relocations in non-relocatable object files.
+
+# RUN: yaml2obj --docnum=1 %s -o %t1
+# RUN: llvm-objdump -r %t1 | FileCheck %s -DFILE=%t1 --check-prefix=FMT --implicit-check-not={{.}}
+# RUN: yaml2obj --docnum=2 %s -o %t2
+# RUN: llvm-objdump -r %t2 | FileCheck %s -DFILE=%t2 --check-prefix=FMT --implicit-check-not={{.}}
+# RUN: yaml2obj --docnum=3 %s -o %t3
+# RUN: llvm-objdump -r %t3 | FileCheck %s -DFILE=%t3 --check-prefixes=FMT,REL --implicit-check-not={{.}}
+
+# FMT: [[FILE]]: file format ELF64-x86-64
+
+# REL:      RELOCATION RECORDS FOR []:
+# REL-NEXT: 0000000000000123 R_X86_64_NONE *ABS*+321
+
+## Executable.
+--- !ELF
+FileHeader:
+  Class:   ELFCLASS64
+  Data:    ELFDATA2LSB
+  Type:    ET_EXEC
+  Machine: EM_X86_64
+Sections:
+  - Name: .rela.plt
+    Type: SHT_RELA
+    Relocations:
+      - Offset: 0x123
+        Type:   R_X86_64_NONE
+        Addend: 321
+
+## DSO.
+--- !ELF
+FileHeader:
+  Class:   ELFCLASS64
+  Data:    ELFDATA2LSB
+  Type:    ET_DYN
+  Machine: EM_X86_64
+Sections:
+  - Name: .rela.plt
+    Type: SHT_RELA
+    Relocations:
+      - Offset: 0x123
+        Type:   R_X86_64_NONE
+        Addend: 321
+
+## Relocatable.
+--- !ELF
+FileHeader:
+  Class:   ELFCLASS64
+  Data:    ELFDATA2LSB
+  Type:    ET_REL
+  Machine: EM_X86_64
+Sections:
+  - Name: .rela.plt
+    Type: SHT_RELA
+    Relocations:
+      - Offset: 0x123
+        Type:   R_X86_64_NONE
+        Addend: 321

llvm/test/tools/llvm-readobj/elf-reloc-no-sym.test

+## Check llvm-readobj is able to dump relocations that
+## do not use symbols. 
+
+# RUN: yaml2obj %s -o %t
+# RUN: llvm-readobj -r %t | FileCheck %s
+
+# CHECK:      Relocations [
+# CHECK-NEXT:   Section (1) .rela.plt {
+# CHECK-NEXT:     0x12345678 R_X86_64_IRELATIVE - 0x87654321
+# CHECK-NEXT:   }
+# CHECK-NEXT: ]
+
+--- !ELF
+FileHeader:
+  Class:   ELFCLASS64
+  Data:    ELFDATA2LSB
+  Type:    ET_EXEC
+  Machine: EM_X86_64
+Sections:
+  - Name:  .rela.plt
+    Type:  SHT_RELA
+    Flags: [ SHF_ALLOC ]
+    Relocations:
+      - Offset: 0x12345678
+        Type:   R_X86_64_IRELATIVE
+        Addend: 0x87654321