This is an archive of the discontinued LLVM Phabricator instance.

Differential D66218

[WebAssembly] Lower SIMD shifts since they are fixed in V8
AbandonedPublic

Authored by bvibber on Aug 14 2019, 6:33 AM.

Details

Reviewers
None
Summary

Reapply https://reviews.llvm.org/D58800 since V8 has fixed this
in https://chromium-review.googlesource.com/c/v8/v8/+/1722198

Diff Detail

Event Timeline

bvibber created this revision.Aug 14 2019, 6:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 14 2019, 6:33 AM
Herald added subscribers: llvm-commits, sunfish, aheejin and 4 others. · View Herald Transcript
Harbormaster completed remote builds in B36738: Diff 215105.Aug 14 2019, 6:33 AM
aheejin added a subscriber: tlively.Aug 14 2019, 8:17 AM

@tlively fixed it in D66166 :)

bvibber abandoned this revision.Aug 14 2019, 10:56 AM

Closing; same change was applied as D66166 :)

Revision Contents

PathSize
llvm/
lib/
Target/
WebAssembly/
5 lines

Diff 215105

llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp

Show First 20 Lines • Show All 1,443 Lines • ▼ Show 20 Lines
SDValue WebAssemblyTargetLowering::LowerShift(SDValue Op, SDValue WebAssemblyTargetLowering::LowerShift(SDValue Op,
SelectionDAG &DAG) const { SelectionDAG &DAG) const {
SDLoc DL(Op); SDLoc DL(Op);
// Only manually lower vector shifts // Only manually lower vector shifts
assert(Op.getSimpleValueType().isVector()); assert(Op.getSimpleValueType().isVector());
// Expand all vector shifts until V8 fixes its implementation
// TODO: remove this once V8 is fixed
if (!Subtarget->hasUnimplementedSIMD128())
return unrollVectorShift(Op, DAG);
// Unroll non-splat vector shifts // Unroll non-splat vector shifts
BuildVectorSDNode *ShiftVec; BuildVectorSDNode *ShiftVec;
SDValue SplatVal; SDValue SplatVal;
if (!(ShiftVec = dyn_cast<BuildVectorSDNode>(Op.getOperand(1).getNode())) || if (!(ShiftVec = dyn_cast<BuildVectorSDNode>(Op.getOperand(1).getNode())) ||
!(SplatVal = ShiftVec->getSplatValue())) !(SplatVal = ShiftVec->getSplatValue()))
return unrollVectorShift(Op, DAG); return unrollVectorShift(Op, DAG);
// All splats except i64x2 const splats are handled by patterns // All splats except i64x2 const splats are handled by patterns
Show All 27 Lines