This is an archive of the discontinued LLVM Phabricator instance.

[Codegen] Updated test for D66158
ClosedPublic

Authored by xbolva00 on Aug 13 2019, 2:41 PM.

Diff Detail

Event Timeline

xbolva00 created this revision.Aug 13 2019, 2:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 13 2019, 2:41 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Might not be the best test given that this should arguably be a memset not a memcpy.

hm.. memset?

xbolva00 updated this revision to Diff 214940.Aug 13 2019, 3:12 PM

Explicit memcpy

jdoerfert accepted this revision.Aug 13 2019, 3:23 PM

hm.. memset?

When I say memset, here and in the other review, I mean memmove.

Explicit memcpy

thx. LGTM.

This revision is now accepted and ready to land.Aug 13 2019, 3:23 PM
xbolva00 updated this revision to Diff 215039.Aug 14 2019, 1:18 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 14 2019, 1:33 AM