Page MenuHomePhabricator

[OpenCL][PR42385] Improve addr space deduction for pointers/references to arrays
ClosedPublic

Authored by Anastasia on Aug 13 2019, 4:32 AM.

Details

Summary

Rewrite the logic for detecting if we are deducing addr space of a pointee type to take into account special logic for arrays.
For pointer/references to arrays we can have any number of parenthesis expressions as well as nested pointers.

Diff Detail

Repository
rL LLVM

Event Timeline

Anastasia created this revision.Aug 13 2019, 4:32 AM
Anastasia retitled this revision from [OpenCL][PR42385]Improve addr space deduction for pointers/references to arrays to [OpenCL][PR42385] Improve addr space deduction for pointers/references to arrays.Aug 13 2019, 4:33 AM
svenvh accepted this revision.Mon, Aug 19, 2:15 AM

LGTM, but please clang-format your patch before committing (esp. spacing around binary operators).

lib/Sema/SemaType.cpp
7396 ↗(On Diff #214806)

parentheses (also below).

This revision is now accepted and ready to land.Mon, Aug 19, 2:15 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMon, Aug 19, 4:44 AM