Page MenuHomePhabricator

[GWP-ASan] Update backtrace function signature.
ClosedPublic

Authored by hctim on Aug 12 2019, 11:19 AM.

Details

Summary

Updates the function signature and comments for backtracing (and printing
backtraces). This update brings GWP-ASan in line with future requirements for
stack frame compression, wherein the length of the trace is provided
explicitly, rather than relying on nullptr-termination.

Diff Detail

Repository
rL LLVM

Event Timeline

hctim created this revision.Aug 12 2019, 11:19 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 12 2019, 11:19 AM
Herald added subscribers: llvm-commits, Restricted Project. · View Herald Transcript
vlad.tsyrklevich accepted this revision.Aug 12 2019, 1:02 PM
vlad.tsyrklevich added inline comments.
compiler-rt/lib/gwp_asan/options.h
24 ↗(On Diff #214672)

Replace tabs with spaces.

This revision is now accepted and ready to land.Aug 12 2019, 1:02 PM
hctim updated this revision to Diff 214702.Aug 12 2019, 2:07 PM
hctim marked 2 inline comments as done.
  • Update comment format.
compiler-rt/lib/gwp_asan/options.h
24 ↗(On Diff #214672)

This actually got caught up in my comment auto-formatter and it mucked it up. Have fixed it up, thanks for the catch.

This revision was automatically updated to reflect the committed changes.