Page MenuHomePhabricator

Fix environment variable passing in libc++'s `SSHExecutor` `lit` utility
ClosedPublic

Authored by wash on Aug 8 2019, 10:21 AM.

Details

Summary

Quote the value of environment variables when passing them to the SSH client in SSHExecutor in libc++'s lit utilities. Without the quotes, an environment variable like FOO="buzz bar" gets passed incorrectly like this, ssh env FOO=buzz bar, which causes bar to be treated as a command to run, not part of the environment variable value.

We ran into this when using SSHExecutor to do bringup of our CUDA libcu++ port on an embedded aarch64 system.

Diff Detail

Repository
rL LLVM

Event Timeline

wash created this revision.Aug 8 2019, 10:21 AM
ldionne accepted this revision.Aug 8 2019, 10:32 AM
This revision is now accepted and ready to land.Aug 8 2019, 10:32 AM
This revision was automatically updated to reflect the committed changes.