Page MenuHomePhabricator

For explicit sections, limit unique section ids to when fintegrated-as=true.
AcceptedPublic

Authored by rahmanl on Aug 6 2019, 5:20 PM.

Details

Reviewers
pcc
dblaikie
Summary

This limits the applicability of r367501 to the integrated assembler because the gnu-assembler does not recognize unique section ids.

Diff Detail

Event Timeline

rahmanl created this revision.Aug 6 2019, 5:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 6 2019, 5:20 PM
rahmanl updated this revision to Diff 213930.Aug 7 2019, 9:47 AM
rahmanl edited the summary of this revision. (Show Details)

Added test case.

dblaikie accepted this revision.Aug 7 2019, 10:03 AM

Looks good - thanks! (still seems like if the syntax for no-unique-section-names is only supported by the integrated assembler, then this feature should also be gated by that flag too (or that flag shouldn't exist and be implied by the use of the integrated assembler?))

This revision is now accepted and ready to land.Aug 7 2019, 10:03 AM

Was this or some other solution committed?

The original commit that this revision was trying to fix was reverted in rG885fa02da97a9f4d15f05fd7ec9c1358c47dd125 due to other technical reasons that this revision was not aiming to fix.