This is an archive of the discontinued LLVM Phabricator instance.

Differential D65703

Fix typo in GN build configuration
ClosedPublic

Authored by mehdi_amini on Aug 3 2019, 2:25 PM.

Download Raw Diff

Details

Reviewers

thakis
phosek

Diff Detail

Repository

rG LLVM Github Monorepo

Build Status

Buildable 36072
Build 36071: arc lint + arc unit

Event Timeline

mehdi_amini created this revision.Aug 3 2019, 2:25 PM

Herald added a project: Restricted Project. · View Herald TranscriptAug 3 2019, 2:25 PM

Harbormaster completed remote builds in B36072: Diff 213203.Aug 3 2019, 2:26 PM

LGTM

This revision is now accepted and ready to land.Aug 4 2019, 12:56 AM

r364162 fixed this

Revision Contents

Path

Size

llvm/

utils/

gn/

secondary/

compiler-rt/

lib/

builtins/

2 lines

Diff 213203

llvm/utils/gn/secondary/compiler-rt/lib/builtins/BUILD.gn

	Show First 20 Lines • Show All 153 Lines • ▼ Show 20 Lines		sources = [
	# This depends on unwind.h which is present in Clang headers. We should			# This depends on unwind.h which is present in Clang headers. We should
	# reconsider this if we ever decide to support building builtins with			# reconsider this if we ever decide to support building builtins with
	# other compilers.			# other compilers.
	"gcc_personality_v0.c",			"gcc_personality_v0.c",
	]			]

	if (target_os != "fuchsia") {			if (target_os != "fuchsia") {
	sources += [			sources += [
	"emutls.c ",			"emutls.c",
	"enable_execute_stack.c",			"enable_execute_stack.c",
	"eprintf.c",			"eprintf.c",
	]			]
	}			}

	if (target_os != "fuchsia" && !compiler_rt_baremetal_build) {			if (target_os != "fuchsia" && !compiler_rt_baremetal_build) {
	sources += [			sources += [
	# This comment prevents `gn format` from putting the file on the same line			# This comment prevents `gn format` from putting the file on the same line
	▲ Show 20 Lines • Show All 314 Lines • Show Last 20 Lines