Page MenuHomePhabricator

[lit] Fix 42812: lit test suite can no longer be run stand-alone
ClosedPublic

Authored by stella.stamenova on Aug 2 2019, 1:28 PM.

Details

Summary

This change updates the lit.cfg file to use llvm_config when it is available, but when it is not, it directly modifies the config object. This makes it possible to run the lit tests standalone without having built llvm (as long as the correct binaries are present in the path such as FileCheck and not).

Because the lit tests don't take a hard dependency on llvm_config, some features such as system-windows have to have definitions in lit's cfg file as well. This is a potential issue as the os features sometimes change names (for example, we went from windows to system-windows, etc.). This can cause drift between lit's tests and the rest of the llvm tests.

Diff Detail

Repository
rL LLVM

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptAug 2 2019, 1:28 PM
stella.stamenova added a comment.EditedAug 2 2019, 1:29 PM

@mgorny Could you download the patch and see if it fixes your scenario? I tested it on both Ubuntu and Linux, but neither installation of LLVM I have actually contains FileCheck or not, so my setup is not entirely the same as yours.

[edit] That would be both Ubuntu and Windows not Ubuntu and Linux. Duh.

mgorny accepted this revision.Aug 2 2019, 2:11 PM

WFM.

This revision is now accepted and ready to land.Aug 2 2019, 2:11 PM
This revision was automatically updated to reflect the committed changes.