Page MenuHomePhabricator

Sidestep false positive due to a matching git repository name
ClosedPublic

Authored by rogfer01 on Thu, Aug 1, 11:49 PM.

Details

Summary

I have failures in this test because the grep @b gets confused by the clang version including a repository name like this

!1 = !{!"clang version 10.0.0 (git@build-machine:llvm/llvm-monorepo.git fe958c0e8c89ec663c8e551936778e2cbb460154)"}

I considered something like grep -w but my understanding of the manpages was that that isn't super portable. So I think it is easier to make clang not to output that metadata using -fno-ident.

Diff Detail

Repository
rL LLVM

Event Timeline

rogfer01 created this revision.Thu, Aug 1, 11:49 PM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Aug 1, 11:49 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
rogfer01 edited reviewers, added: efriedma; removed: eli.friedman.Thu, Aug 1, 11:50 PM
efriedma accepted this revision.Fri, Aug 2, 10:41 AM

LGTM

It would be cleaner to convert this test to FileCheck, but it's probably not worth spending the time at this point.

This revision is now accepted and ready to land.Fri, Aug 2, 10:41 AM

Thanks @efriedma. I will commit this shortly.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMon, Aug 5, 3:10 AM