Page MenuHomePhabricator

[clang] Fix mismatched args constructing AddressSpaceAttr.
ClosedPublic

Authored by AntonBikineev on Aug 1 2019, 10:20 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

AntonBikineev created this revision.Aug 1 2019, 10:20 AM

This really needs a test, likely an astdump-one will show it.

Roman, -ast-dump shows the correct result, because the correct address space is encoded in qualifiers and is passed to Context.getAddrSpaceQualType(...) later in this function. This is why this bug is not observable from the AST. But if you try accessing real Attr* from TypeSourceInfo, you'll see this mismatch.

Pinging for review..

This revision was not accepted when it landed; it landed in state Needs Review.Aug 7 2019, 4:15 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 7 2019, 4:15 AM