Page MenuHomePhabricator

AntonBikineev (Anton Bikineev)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 12 2014, 7:28 AM (257 w, 2 d)

Recent Activity

Aug 7 2019

AntonBikineev committed rG45f721ff0594: [clang] Fix mismatched args constructing AddressSpaceAttr. (authored by AntonBikineev).
[clang] Fix mismatched args constructing AddressSpaceAttr.
Aug 7 2019, 4:15 AM
AntonBikineev committed rL368152: [clang] Fix mismatched args constructing AddressSpaceAttr..
[clang] Fix mismatched args constructing AddressSpaceAttr.
Aug 7 2019, 4:15 AM
AntonBikineev closed D65589: [clang] Fix mismatched args constructing AddressSpaceAttr..
Aug 7 2019, 4:15 AM · Restricted Project, Restricted Project

Aug 5 2019

AntonBikineev added a comment to D65589: [clang] Fix mismatched args constructing AddressSpaceAttr..

Ping.

Aug 5 2019, 3:48 AM · Restricted Project, Restricted Project

Aug 2 2019

AntonBikineev added a comment to D65589: [clang] Fix mismatched args constructing AddressSpaceAttr..

Pinging for review..

Aug 2 2019, 12:36 PM · Restricted Project, Restricted Project

Aug 1 2019

AntonBikineev updated the diff for D65589: [clang] Fix mismatched args constructing AddressSpaceAttr..

Roman, -ast-dump shows the correct result, because the correct address space is encoded in qualifiers and is passed to Context.getAddrSpaceQualType(...) later in this function. This is why this bug is not observable from the AST. But if you try accessing real Attr* from TypeSourceInfo, you'll see this mismatch.

Aug 1 2019, 12:37 PM · Restricted Project, Restricted Project
AntonBikineev created D65589: [clang] Fix mismatched args constructing AddressSpaceAttr..
Aug 1 2019, 10:22 AM · Restricted Project, Restricted Project

Jul 25 2019

AntonBikineev committed rG207726c8825a: [clang] Remove IsDerivedFromDeathTest.DiesOnEmptyBaseName test. (authored by AntonBikineev).
[clang] Remove IsDerivedFromDeathTest.DiesOnEmptyBaseName test.
Jul 25 2019, 8:12 AM
AntonBikineev committed rL367026: [clang] Remove IsDerivedFromDeathTest.DiesOnEmptyBaseName test..
[clang] Remove IsDerivedFromDeathTest.DiesOnEmptyBaseName test.
Jul 25 2019, 8:12 AM
AntonBikineev committed rG0ef3f27458f5: [clang] Fail for empty names in is*DerivedFrom matchers. (authored by AntonBikineev).
[clang] Fail for empty names in is*DerivedFrom matchers.
Jul 25 2019, 7:50 AM
AntonBikineev committed rL367022: [clang] Fail for empty names in is*DerivedFrom matchers..
[clang] Fail for empty names in is*DerivedFrom matchers.
Jul 25 2019, 7:50 AM
AntonBikineev closed D65279: [clang] Fail for empty names in is*DerivedFrom matchers..
Jul 25 2019, 7:50 AM · Restricted Project, Restricted Project
AntonBikineev created D65279: [clang] Fail for empty names in is*DerivedFrom matchers..
Jul 25 2019, 6:18 AM · Restricted Project, Restricted Project
AntonBikineev committed rG4e1d188be286: [clang] Add isDirectlyDerivedFrom AST matcher. (authored by AntonBikineev).
[clang] Add isDirectlyDerivedFrom AST matcher.
Jul 25 2019, 4:58 AM
AntonBikineev committed rL367010: [clang] Add isDirectlyDerivedFrom AST matcher..
[clang] Add isDirectlyDerivedFrom AST matcher.
Jul 25 2019, 4:54 AM
AntonBikineev closed D65092: [clang] Add isDirectlyDerivedFrom AST Matcher..
Jul 25 2019, 4:53 AM · Restricted Project, Restricted Project

Jul 24 2019

AntonBikineev updated the diff for D65092: [clang] Add isDirectlyDerivedFrom AST Matcher..

Missed that, thanks for the point!

Jul 24 2019, 8:16 AM · Restricted Project, Restricted Project
AntonBikineev added inline comments to D65092: [clang] Add isDirectlyDerivedFrom AST Matcher..
Jul 24 2019, 7:58 AM · Restricted Project, Restricted Project
AntonBikineev updated the diff for D65092: [clang] Add isDirectlyDerivedFrom AST Matcher..

Thanks for the comments!

Jul 24 2019, 7:58 AM · Restricted Project, Restricted Project
AntonBikineev added a comment to D65092: [clang] Add isDirectlyDerivedFrom AST Matcher..

Manuel, would you mind taking another look at the change please?

Jul 24 2019, 5:13 AM · Restricted Project, Restricted Project

Jul 23 2019

AntonBikineev updated the diff for D65092: [clang] Add isDirectlyDerivedFrom AST Matcher..

Thanks for the note, updated the diff with autogenerated LibASTMatcherReference.html.

Jul 23 2019, 1:52 AM · Restricted Project, Restricted Project

Jul 22 2019

AntonBikineev updated the diff for D65092: [clang] Add isDirectlyDerivedFrom AST Matcher..

Manuel, I left some cases which deviated from the isDerivedFrom matcher.

Jul 22 2019, 10:59 AM · Restricted Project, Restricted Project
AntonBikineev added a reviewer for D65092: [clang] Add isDirectlyDerivedFrom AST Matcher.: klimek.
Jul 22 2019, 9:45 AM · Restricted Project, Restricted Project
AntonBikineev created D65092: [clang] Add isDirectlyDerivedFrom AST Matcher..
Jul 22 2019, 7:14 AM · Restricted Project, Restricted Project

Nov 7 2018

AntonBikineev added a comment to rL344150: [CodeGenCXX] Treat 'this' as noalias in constructors.

@inouehrs thanks a lot, jut was granted with the access to the farm.

Nov 7 2018, 4:35 AM

Oct 26 2018

AntonBikineev added a comment to rL344150: [CodeGenCXX] Treat 'this' as noalias in constructors.

@inouehrs I would be happy to work on the issue and find out what really causes the segfaults. Unfortunately, I don't have a ppc working machine, compiling clang in qemu emulating ppc took me over 3 days. Do you know of any cloud vps services based on power pc?

Oct 26 2018, 10:54 AM

Oct 14 2018

AntonBikineev added a comment to rL344150: [CodeGenCXX] Treat 'this' as noalias in constructors.

@AntonBikineev It seems that this patch is causing failures in a ppc64 buildbot http://lab.llvm.org:8011/builders/clang-ppc64le-linux-multistage/ . Do you have any idea on the reason of the problem by looking at the errors?

Oct 14 2018, 10:43 AM

Oct 10 2018

AntonBikineev added a comment to D46441: [clang][CodeGenCXX] Noalias attr for 'this' parameter.

@rsmith, thanks. Le'ts see if there is a need for the command-line option down the road.

Oct 10 2018, 9:19 AM · Restricted Project
AntonBikineev committed rC344150: [CodeGenCXX] Treat 'this' as noalias in constructors.
[CodeGenCXX] Treat 'this' as noalias in constructors
Oct 10 2018, 9:18 AM
AntonBikineev committed rL344150: [CodeGenCXX] Treat 'this' as noalias in constructors.
[CodeGenCXX] Treat 'this' as noalias in constructors
Oct 10 2018, 9:18 AM
AntonBikineev closed D46441: [clang][CodeGenCXX] Noalias attr for 'this' parameter.
Oct 10 2018, 9:17 AM · Restricted Project

Oct 8 2018

AntonBikineev added a comment to D46441: [clang][CodeGenCXX] Noalias attr for 'this' parameter.

@rjmccall thanks for taking a look,
@rsmith do you have any comments or suggestions?

Oct 8 2018, 11:14 AM · Restricted Project
AntonBikineev updated the diff for D46441: [clang][CodeGenCXX] Noalias attr for 'this' parameter.
Oct 8 2018, 5:01 AM · Restricted Project

Oct 6 2018

AntonBikineev updated the diff for D46441: [clang][CodeGenCXX] Noalias attr for 'this' parameter.
Oct 6 2018, 6:30 PM · Restricted Project
AntonBikineev added a comment to D46441: [clang][CodeGenCXX] Noalias attr for 'this' parameter.

I've submitted an issue to the Core about the case. Presumably, it will be included in the next revision (mailing deadline of which is tomorrow).

Oct 6 2018, 6:29 PM · Restricted Project

Oct 4 2018

AntonBikineev updated the diff for D46441: [clang][CodeGenCXX] Noalias attr for 'this' parameter.

ClangToLLVMArgMapping is now used to get LLVM argument corresponding to 'this'.

Oct 4 2018, 10:24 AM · Restricted Project

May 12 2018

AntonBikineev updated the diff for D46441: [clang][CodeGenCXX] Noalias attr for 'this' parameter.

Thanks for the remarkable note. I've updated the patch and marked the first llvm::Function parameter with noalias attribute. Please notice, that this is not the only place where the position of the this pointer is assumed to always be first. As an example, another such place is here. Maybe we will have to generalize it in CGCXXABI down the road...

May 12 2018, 5:17 AM · Restricted Project

May 5 2018

AntonBikineev added a comment to D46441: [clang][CodeGenCXX] Noalias attr for 'this' parameter.

@efriedma copy and move constructors are particular cases where the value of a constructed object may be accessed through a glvalue not obtained from 'this' pointer (but from the first arg of a ctor).

May 5 2018, 4:16 AM · Restricted Project

May 4 2018

AntonBikineev updated the diff for D46441: [clang][CodeGenCXX] Noalias attr for 'this' parameter.

I've moved setting noalias-attribute down to IR-function creation. This is needed in the context of emitting a constructor call when the definition of the constructor is not available (and clang emits an IR-constructor-declaration). @lebedev.ri @aaron.ballman I've also adjusted existing tests. There a quite a few of them, so it seems there is no reason of having a specific test case.

May 4 2018, 5:30 PM · Restricted Project
AntonBikineev created D46441: [clang][CodeGenCXX] Noalias attr for 'this' parameter.
May 4 2018, 10:42 AM · Restricted Project

Feb 10 2018

AntonBikineev added a comment to D43153: [clang] Implement P0692 "Access Checking on Specializations".

@rsmith Thanks for pointing out this example. Now I see that I misunderstood the wording.
Another question is that in the provided example you say that the following line

template<typename T> A::B x<T*>; // ok!

should suppress the error of accessing private A::B. But in the wording it's said that

Feb 10 2018, 5:55 PM

Feb 9 2018

AntonBikineev created D43153: [clang] Implement P0692 "Access Checking on Specializations".
Feb 9 2018, 7:07 PM

Jan 23 2018

AntonBikineev abandoned D27162: Support relaxed constexpr on chrono::duration operations.
Jan 23 2018, 4:01 AM
AntonBikineev abandoned D27199: [libcxx] Make std::ignore constexpr.
Jan 23 2018, 4:00 AM
AntonBikineev closed D42341: [LLVM][PASSES][InstSimplify] Add (X << Y) % X -> 0.
Jan 23 2018, 1:47 AM
AntonBikineev added an edge to rL323182: [InstSimplify] (X << Y) % X -> 0: D42341: [LLVM][PASSES][InstSimplify] Add (X << Y) % X -> 0.
Jan 23 2018, 1:39 AM
AntonBikineev added 1 commit(s) for D42341: [LLVM][PASSES][InstSimplify] Add (X << Y) % X -> 0: rL323182: [InstSimplify] (X << Y) % X -> 0.
Jan 23 2018, 1:39 AM
AntonBikineev added a comment to D42341: [LLVM][PASSES][InstSimplify] Add (X << Y) % X -> 0.

Looking at https://reviews.llvm.org/people/revisions/1398/ i think you can ask for the commit rights now. Just a thought.

Jan 23 2018, 1:37 AM
AntonBikineev committed rL323182: [InstSimplify] (X << Y) % X -> 0.
[InstSimplify] (X << Y) % X -> 0
Jan 23 2018, 1:29 AM

Jan 21 2018

AntonBikineev updated the diff for D42341: [LLVM][PASSES][InstSimplify] Add (X << Y) % X -> 0.
Jan 21 2018, 7:48 AM

Jan 20 2018

AntonBikineev created D42342: [LLVM][InstSimplify] add baseline tests for (X << Y) % X -> 0.
Jan 20 2018, 6:42 PM
AntonBikineev created D42341: [LLVM][PASSES][InstSimplify] Add (X << Y) % X -> 0.
Jan 20 2018, 6:39 PM
AntonBikineev updated the diff for D42032: [LLVM][PASSES][InstCombine] Fix (a + a + ...) / a cases.
Jan 20 2018, 5:10 PM
AntonBikineev added a comment to D42032: [LLVM][PASSES][InstCombine] Fix (a + a + ...) / a cases.

I also prefer to check all of the tests in first to show the current output of trunk. That way if your code commit is reverted for some reason, at least the tests will survive and show what was lost by the revert.

check all of the tests in

check<..>in == commit

Right - sorry, my writing was lousy there. Let me commit the tests now to demonstrate what I was hoping for. :)

Sure, go ahead :)

Jan 20 2018, 8:17 AM
AntonBikineev added a comment to D42032: [LLVM][PASSES][InstCombine] Fix (a + a + ...) / a cases.

I also prefer to check all of the tests in first to show the current output of trunk. That way if your code commit is reverted for some reason, at least the tests will survive and show what was lost by the revert.

I've checked all the test on my machine. The only one that failed was CodeGen/Generic/dwarf-md5.ll:

error: expected string not found in input
; OBJ-5: Dir MD5 Checksum File Name

but it doesn't seem to relate to the change.

Jan 20 2018, 7:53 AM
AntonBikineev updated the diff for D42032: [LLVM][PASSES][InstCombine] Fix (a + a + ...) / a cases.
Jan 20 2018, 7:44 AM

Jan 19 2018

AntonBikineev added a comment to D42032: [LLVM][PASSES][InstCombine] Fix (a + a + ...) / a cases.

This looks right, but see inline comments for some small improvements. Do you have commit access?

No, unfortunately.

Jan 19 2018, 2:17 PM

Jan 18 2018

AntonBikineev updated the diff for D42032: [LLVM][PASSES][InstCombine] Fix (a + a + ...) / a cases.

Is it better to just add that to instcombine and forego adding the special-case with constant shift amount to instsimplify?

Yes, I think so. Thanks for indicating this.

Jan 18 2018, 5:49 PM

Jan 17 2018

AntonBikineev updated the diff for D42032: [LLVM][PASSES][InstCombine] Fix (a + a + ...) / a cases.

@lebedev.ri
My pleasure. Thanks for reviewing this!
@majnemer
Done.

Jan 17 2018, 5:41 PM

Jan 15 2018

AntonBikineev updated the diff for D42032: [LLVM][PASSES][InstCombine] Fix (a + a + ...) / a cases.

As the description shows, it's absolutely right. Thanks for pointing this out.

Jan 15 2018, 3:24 AM

Jan 14 2018

AntonBikineev added a comment to D42032: [LLVM][PASSES][InstCombine] Fix (a + a + ...) / a cases.

Hey Roman,
Thanks for the comments.

  1. Please upload patches with full context (-U999999)

Done.

  1. This needs testing coverage https://bugs.llvm.org/show_bug.cgi?id=35709#c1 notes that "(x+x+x)/x" is already handled, so maybe search for it and look how it is tested? And given that this is a generalization of that, perhaps that one is no longer needed?

The "(x+x+x)/x" case is handled because "(x+x+x)" gets turned into "mul %x, 3" and then another simplification "(x * y) / x -> y" takes place. Things like "x+x" (with power-of-2 number of terms) in turn, get simplified into "shl %x, constant". So it's not a generalization, but a particular case.

Jan 14 2018, 6:43 PM
AntonBikineev updated the diff for D42032: [LLVM][PASSES][InstCombine] Fix (a + a + ...) / a cases.
Jan 14 2018, 6:42 PM

Jan 13 2018

AntonBikineev added a reviewer for D42032: [LLVM][PASSES][InstCombine] Fix (a + a + ...) / a cases: llvm-commits.
Jan 13 2018, 8:46 PM
AntonBikineev created D42032: [LLVM][PASSES][InstCombine] Fix (a + a + ...) / a cases.
Jan 13 2018, 8:45 PM

Jul 24 2017

AntonBikineev added a comment to D35661: [clang] Implement P0704: "Fixing const-qualified pointers to members".

ping..

Jul 24 2017, 11:59 AM

Jul 20 2017

AntonBikineev created D35661: [clang] Implement P0704: "Fixing const-qualified pointers to members".
Jul 20 2017, 12:32 AM

Mar 30 2017

AntonBikineev added a comment to D26830: [libcxx] Add string_view literals.

@AntonBikineev when will you be able to make he requested changes? I would like to land this ASAP.

Mar 30 2017, 2:56 AM

Mar 29 2017

AntonBikineev added a comment to D26830: [libcxx] Add string_view literals.

@AntonBikineev when will you be able to make he requested changes? I would like to land this ASAP.

Mar 29 2017, 4:32 AM

Dec 13 2016

AntonBikineev added a comment to D26830: [libcxx] Add string_view literals.

Please ping this once the Clang changes have been accepted. I'm just waiting on those to give this the final OK.

Dec 13 2016, 5:03 AM
AntonBikineev added a comment to D27199: [libcxx] Make std::ignore constexpr.

@AntonBikineev Do you need somebody to commit this for you?

Dec 13 2016, 5:01 AM

Nov 29 2016

AntonBikineev added a comment to D26829: [clang] Allow lexer to handle string_view literals.

@rsmith Richard, any plans to merge this or is there anything left?

Nov 29 2016, 3:59 AM
AntonBikineev retitled D27199: [libcxx] Make std::ignore constexpr from to [libcxx] Make std::ignore constexpr.
Nov 29 2016, 3:56 AM

Nov 28 2016

AntonBikineev updated the diff for D27162: Support relaxed constexpr on chrono::duration operations.
Nov 28 2016, 6:11 PM
AntonBikineev retitled D27162: Support relaxed constexpr on chrono::duration operations from to Support relaxed constexpr on chrono::duration operations.
Nov 28 2016, 5:20 AM

Nov 24 2016

AntonBikineev added inline comments to D26896: [libcxx] Make constexpr char_traits<T> and char_traits<char>.
Nov 24 2016, 5:10 AM
AntonBikineev updated the diff for D26896: [libcxx] Make constexpr char_traits<T> and char_traits<char>.

Support gcc's __builtin_memcpy, memchr, strlen

Nov 24 2016, 4:53 AM

Nov 23 2016

AntonBikineev updated subscribers of D26859: [libcxx] Introducing _LIBCPP_INLINE_VARIABLE.

I didn't add _LIBCPP_INLINE_VARIABLE because we shouldn't make a habit of having variables that are sometimes inline and sometimes not. So it should be as ugly as possible when you have to do it. Hopefully the current usages in <utility> will be all we ever need.

Nov 23 2016, 7:41 AM

Nov 21 2016

AntonBikineev updated the diff for D26896: [libcxx] Make constexpr char_traits<T> and char_traits<char>.
Nov 21 2016, 1:37 PM
AntonBikineev updated the diff for D26829: [clang] Allow lexer to handle string_view literals.
Nov 21 2016, 10:18 AM

Nov 20 2016

AntonBikineev updated D26896: [libcxx] Make constexpr char_traits<T> and char_traits<char>.
Nov 20 2016, 8:01 AM
AntonBikineev retitled D26896: [libcxx] Make constexpr char_traits<T> and char_traits<char> from to [libcxx] Make constexpr char_traits<T> and char_traits<char>.
Nov 20 2016, 8:01 AM
AntonBikineev updated the diff for D26829: [clang] Allow lexer to handle string_view literals.

Richard, thanks, I addressed your comments.

Nov 20 2016, 2:12 AM

Nov 19 2016

AntonBikineev added inline comments to D26829: [clang] Allow lexer to handle string_view literals.
Nov 19 2016, 2:36 AM

Nov 18 2016

AntonBikineev added a comment to D26829: [clang] Allow lexer to handle string_view literals.

Does Sema::CheckLiteralOperatorDeclaration need to check StringLiteralParser::isValidUDSuffix?

Nov 18 2016, 4:41 PM
AntonBikineev updated the diff for D26829: [clang] Allow lexer to handle string_view literals.
Nov 18 2016, 4:40 PM
AntonBikineev added a reviewer for D26859: [libcxx] Introducing _LIBCPP_INLINE_VARIABLE: mclow.lists.
Nov 18 2016, 8:19 AM
AntonBikineev retitled D26859: [libcxx] Introducing _LIBCPP_INLINE_VARIABLE from to [libcxx] Introducing _LIBCPP_INLINE_VARIABLE.
Nov 18 2016, 8:18 AM
AntonBikineev updated the diff for D26830: [libcxx] Add string_view literals.

Fixing typos...

Nov 18 2016, 8:12 AM
AntonBikineev updated the diff for D26829: [clang] Allow lexer to handle string_view literals.

Just added a small test case

Nov 18 2016, 7:19 AM
AntonBikineev updated the diff for D26829: [clang] Allow lexer to handle string_view literals.
Nov 18 2016, 6:12 AM
AntonBikineev updated the diff for D26829: [clang] Allow lexer to handle string_view literals.
Nov 18 2016, 6:04 AM
AntonBikineev updated the diff for D26829: [clang] Allow lexer to handle string_view literals.
Nov 18 2016, 6:03 AM
AntonBikineev added inline comments to D26830: [libcxx] Add string_view literals.
Nov 18 2016, 4:16 AM
AntonBikineev updated the diff for D26830: [libcxx] Add string_view literals.
Nov 18 2016, 4:13 AM
AntonBikineev updated the diff for D26830: [libcxx] Add string_view literals.
Nov 18 2016, 4:11 AM
AntonBikineev updated D26830: [libcxx] Add string_view literals.
Nov 18 2016, 3:18 AM
AntonBikineev added inline comments to D26830: [libcxx] Add string_view literals.
Nov 18 2016, 3:12 AM
AntonBikineev updated the diff for D26830: [libcxx] Add string_view literals.
Nov 18 2016, 3:12 AM
AntonBikineev updated the diff for D26829: [clang] Allow lexer to handle string_view literals.
Nov 18 2016, 2:23 AM

Nov 17 2016

AntonBikineev retitled D26830: [libcxx] Add string_view literals from to [libcxx] Add string_view literals.
Nov 17 2016, 7:19 PM