Refactoring:
+ rename 'Options' to 'EnvVars' to better reflect the variables contents.
+ keep all scan-build arguments in the hash rather then in scattered variables.
All arguments were tested with the debugger. Please review!
Differential D6551
Improvements to scan-build. ClosedPublic Authored by ayartsev on Dec 5 2014, 7:19 AM.
Details Summary Refactoring: All arguments were tested with the debugger. Please review!
Diff Detail Event Timelineayartsev updated this object. Comment Actions + refactoring: moved processing of command-line arguments to a subroutine. Please review! Comment Actions Anna, if you want, as I am a big user of scan-build, I can do the testing of this for you. Comment Actions Anton, Sylvestre, Thank you for the offer! It would be really great if you could help us with testing this. Which platforms are you using this on? Anton has another patch for scan-build in review. See cfe-commits "Prevent ccc/c++-analyzer from hanging on Windows." It might be best if you test all of them together. (Maybe Anton could send you the cumulative patch to save you time.) Comment Actions Anna, just a refactoring, except line 1254 where missing "-Xclang" added before "-load". I'll make a separate patch for this. Comment Actions Ok. Sounds good. Sylvestre, Anton, Comment Actions Anna, Sylvestre, fork_open_hang_v2.patch4 KBDownload Note, this patch is not included in the refactoring patch. Comment Actions The second patch does not apply on top of the first. Comment Actions could you please use phabricator for the second patch and add a dependency on this one? Thanks Comment Actions and, last but not least, the CR are broken. I don't know what you use but it seems that patch detects it as binary. Comment Actions
Yes, these patches are not cumulative. After one of the patches gets in the other must be modified.
Done! Added the second patch as http://reviews.llvm.org/D8774
I'll address this a bit later. Comment Actions
Weird.. Use 'svn diff --diff-cmd=diff -x -U999999' as usual, no specific properties are set on 'scan-build', 'svn proplist -v scan-build' gives: svn:executable * svn:keywords Id Fixed CRs manually, updated the patch.
Could you, please, first test http://reviews.llvm.org/D8774 in order to merge it with the refactoring patch? Comment Actions Ping! Comment Actions This is breaking the build of Firefox with scan-build with: sh: 1: Syntax error: "(" unexpected could not find clang line Full log: By the way, this error message should be improved. This revision now requires changes to proceed.May 3 2015, 12:08 PM Comment Actions I rebuilt Firefox code with this change under Debian and it works great. Comment Actions (if you commit it, please update the description, "Improvements to scan-build" is too general Comment Actions Hi Anton, Since D10356 is committed first, your patch(D6551) has to be modified based on it. I was trying to upload the patch in phabricator, but I don't have a permission to update your patch. Thanks,
Comment Actions Hi Honggyu, The new patch contains changes introduced by r244400 (D10356) and r244673 plus some simplifications. Comment Actions Anton, I think you should just commit it. We can always iterate on this later if it breaks anything. Comment Actions Removed trailing whitespaces and committed as r246710. This revision is now accepted and ready to land.Sep 16 2015, 4:39 AM
Revision Contents
Diff 22727 tools/scan-build/scan-build
|
Trailing whitespace here.