+ rename 'Options' to 'EnvVars' to better reflect the variables contents.
+ keep all scan-build arguments in the hash rather then in scattered variables.
All arguments were tested with the debugger. Please review!
Is all of this just a refactoring? I've noticed a couple of places where new functionality is being added. If that is the case, could you split that into a separate patch, explaining why that is needed.
Thank you for the offer! It would be really great if you could help us with testing this. Which platforms are you using this on?
Anton has another patch for scan-build in review. See cfe-commits "Prevent ccc/c++-analyzer from hanging on Windows." It might be best if you test all of them together. (Maybe Anton could send you the cumulative patch to save you time.)
Ok. Sounds good.
Could you test this patch and the one labeled "Prevent ccc/c++-analyzer from hanging on Windows."?
Does Sylvestre need an updated diff for the other patch?
The second patch does not apply on top of the first.
Hunk #1 succeeded at 1258 (offset 26 lines).
Hunk #2 FAILED at 1242.
Hunk #3 succeeded at 1301 (offset 31 lines).
Hunk #4 succeeded at 1338 (offset 31 lines).
Weird.. Use 'svn diff --diff-cmd=diff -x -U999999' as usual, no specific properties are set on 'scan-build', 'svn proplist -v scan-build' gives:
Properties on 'scan-build':
svn:executable * svn:keywords Id
Fixed CRs manually, updated the patch.
Could you, please, first test http://reviews.llvm.org/D8774 in order to merge it with the refactoring patch?
This is breaking the build of Firefox with scan-build with:
sh: 1: Syntax error: "(" unexpected could not find clang line
By the way, this error message should be improved.
I was trying to upload the patch in phabricator, but I don't have a permission to update your patch.
I just attached the modified version so that you can easily upload it.