Page MenuHomePhabricator

Adjust a ValueObjectChild's offset when the child is a bitfield

Authored by aprantl on Jul 30 2019, 5:19 PM.



If a bitfield doesn't fit into the child_byte_size'd window at child_byte_offset, move the window (= child_byte_offset) forward until it fits.

This was not in the big-endian-derived DWARF 2 bitfield attributes because their offsets were counted from the end of the window, so they always fit.


Diff Detail


Event Timeline

aprantl created this revision.Jul 30 2019, 5:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 30 2019, 5:19 PM

I'm sure this is fine, I read the code through and I've realized I haven't had to do anything with bitfields in lldb up to now.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 7 2019, 3:41 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 7 2019, 3:41 PM