Page MenuHomePhabricator

[docs] Add cmake to Software requirements
ClosedPublic

Authored by rovka on Jul 30 2019, 4:49 AM.

Details

Summary

Add cmake to the list of packages required for compiling LLVM.
Also move make to the bottom of the list and mark it as optional.

Diff Detail

Repository
rL LLVM

Event Timeline

rovka created this revision.Jul 30 2019, 4:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 30 2019, 4:49 AM
sgraenitz accepted this revision.Jul 30 2019, 7:44 AM

Yes, agree! Hopefully we will move on to a newer version (3.9?) some time soon, but that needs a broader discussion first.

This revision is now accepted and ready to land.Jul 30 2019, 7:44 AM
This revision was automatically updated to reflect the committed changes.

This broke the sphinx bot:

http://lab.llvm.org:8011/builders/llvm-sphinx-docs/builds/33901/steps/docs-llvm-html/logs/stdio

Warning, treated as error:
/home/buildbot/llvm-build-dir/llvm-sphinx-docs/llvm/src/docs/GettingStarted.rst:3: WARNING: Duplicate explicit target name: "cmake".

Can you take a look?

This broke the sphinx bot

Interesting. Thanks for pointing it out. However, note that it's more like "failing for a different reason" now :)
http://lab.llvm.org:8011/builders/llvm-sphinx-docs/builds/33900/steps/docs-llvm-html/logs/stdio

llvm/trunk/docs/GettingStarted.rst
98

Is this the other "explicit target name"?

Yup, the other one's at https://reviews.llvm.org/D65164#1608898 , that one has a fix committed by now

This broke the sphinx bot:

http://lab.llvm.org:8011/builders/llvm-sphinx-docs/builds/33901/steps/docs-llvm-html/logs/stdio

Warning, treated as error:
/home/buildbot/llvm-build-dir/llvm-sphinx-docs/llvm/src/docs/GettingStarted.rst:3: WARNING: Duplicate explicit target name: "cmake".

Can you take a look?

Ping, this is still broken 5 days later.

Did you run ninja docs-llvm-html (or equivalent if not using ninja) when submitting? I'm still seeing this error in trunk.