[analyzer] exploded-graph-rewriter: Implement Store pointers.

[NoQ]

Summary

Those are useful for understanding contents of LazyCompoundVals.

[Charusso]

Thanks! Is it working in dark-mode as expected?

clang/utils/analyzer/exploded-graph-rewriter.py

647

Extra space at the start of the string: ' <.

[NoQ]

Hmm, on second thought...
Make the pointers a bit darker in dark mode.

[NoQ]

clang/utils/analyzer/exploded-graph-rewriter.py

647

I'm doing this intentionally because GraphViz's rendering of spaces is pretty weird. Without this space the new text gets agglutinated to the "Store:" caption.

[Charusso]

Oh, of course. Thanks!

clang/test/Analysis/exploded-graph-rewriter/escapes.c

 // FIXME: Figure out how to use %clang_analyze_cc1 with our lit.local.cfg.
 // RUN: %clang_cc1 -analyze -triple x86_64-unknown-linux-gnu \
 // RUN:                     -analyzer-checker=core \
 // RUN:                     -analyzer-dump-egraph=%t.dot %s
 // RUN: %exploded_graph_rewriter %t.dot | FileCheck %s
 // REQUIRES: asserts
 
 // FIXME: Substitution doesn't seem to work on Windows.
 // UNSUPPORTED: system-windows
 
 void escapes() {
-  // CHECK: <td align="left"><b>Store: </b></td>
+  // CHECK: <td align="left"><b>Store: </b> <font color="gray">(0x{{[0-9a-f]*}})</font></td>
   // CHECK-SAME: <td align="left">foo</td><td align="left">0</td>
   // CHECK-SAME: <td align="left">&amp;Element\{"foo",0 S64b,char\}</td>
   // CHECK: <td align="left"><b>Environment: </b></td>
   // CHECK-SAME: <td align="left">"foo"</td>
   // CHECK-SAME: <td align="left">&amp;Element\{"foo",0 S64b,char\}</td>
   const char *const foo = "\x66\x6f\x6f";
 
   // CHECK: <font color="cyan4">BinaryOperator</font>
   // CHECK-SAME: <td align="left">1 \| 2</td>
   // CHECK-SAME: <td align="left">3 S32b</td>
   int x = 1 | 2;
 }

clang/test/Analysis/exploded-graph-rewriter/store.dot

 // RUN: %exploded_graph_rewriter %s | FileCheck %s
 
 // FIXME: Substitution doesn't seem to work on Windows.
 // UNSUPPORTED: system-windows
 
 // CHECK: <b>Store: </b>
+// CHECK-SAME: <font color="gray">(0x2)</font>
 // CHECK-SAME: <table border="0">
 // CHECK-SAME:   <tr>
 // CHECK-SAME:     <td align="left">
 // CHECK-SAME:       x
 // CHECK-SAME:     </td>
 // CHECK-SAME:     <td align="left">
 // CHECK-SAME:       0
 // CHECK-SAME:     </td>

clang/utils/analyzer/exploded-graph-rewriter.py

def visit_store_in_state(self, s, prev_s=None):
         prev_st = prev_s.store if prev_s is not None else None
         if st is None and prev_st is None:
             return
 
         self._dump('<hr /><tr><td align="left"><b>Store: </b>')
         if st is None:
             self._dump('<i> Nothing!</i>')
         else:
+            if self._dark_mode:
+                self._dump(' <font color="gray30">(%s)</font>' % st.ptr)
+            else:
+                self._dump(' <font color="gray">(%s)</font>' % st.ptr)
             if prev_st is not None:
                 if s.store.is_different(prev_st):
                     self._dump('</td></tr><tr><td align="left">')
                     self.visit_store(st, prev_st)
                 else:
                     self._dump('<i> No changes!</i>')
             else:
                 self._dump('</td></tr><tr><td align="left">')