Page MenuHomePhabricator

[analyzer] exploded-graph-rewriter: Implement Store pointers.
ClosedPublic

Authored by NoQ on Mon, Jul 29, 5:13 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

NoQ created this revision.Mon, Jul 29, 5:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptMon, Jul 29, 5:13 PM
Charusso accepted this revision.Mon, Jul 29, 5:22 PM

Thanks! Is it working in dark-mode as expected?

clang/utils/analyzer/exploded-graph-rewriter.py
647 ↗(On Diff #212254)

Extra space at the start of the string: ' <.

This revision is now accepted and ready to land.Mon, Jul 29, 5:22 PM
NoQ updated this revision to Diff 212257.Mon, Jul 29, 5:32 PM

Hmm, on second thought...
Make the pointers a bit darker in dark mode.

NoQ marked an inline comment as done.Mon, Jul 29, 5:36 PM
NoQ added inline comments.
clang/utils/analyzer/exploded-graph-rewriter.py
647 ↗(On Diff #212254)

I'm doing this intentionally because GraphViz's rendering of spaces is pretty weird. Without this space the new text gets agglutinated to the "Store:" caption.

Charusso accepted this revision.Mon, Jul 29, 5:40 PM

Oh, of course. Thanks!

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptTue, Aug 13, 4:05 PM