Page MenuHomePhabricator

add 'a' to chmod in llvm-lipo executability tests
ClosedPublic

Authored by inglorion on Jul 26 2019, 11:36 AM.

Details

Summary

When specifying symbolic permissions with + or -, if none of
a/u/g/o are specified, bits set in the umask are not affected.
This caused the llvm-lipo executability tests to fail on some
systems, e.g. having an umask of 027 would cause chmod -x to not
clear the executable bit for others. This change instead
uses chmod a-x, which clears all the executable bits regardless
of umask.

Diff Detail

Repository
rL LLVM

Event Timeline

inglorion created this revision.Jul 26 2019, 11:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 26 2019, 11:36 AM
smeenai accepted this revision.Jul 26 2019, 11:41 AM
smeenai added a reviewer: anushabasana.

LGTM, thanks!

This revision is now accepted and ready to land.Jul 26 2019, 11:41 AM
This revision was automatically updated to reflect the committed changes.