Page MenuHomePhabricator

[NFC][clang] Refactor getCompilationPhases()+Types.def step 3.
ClosedPublic

Authored by plotfi on Jul 25 2019, 4:27 PM.

Event Timeline

plotfi created this revision.Jul 25 2019, 4:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 25 2019, 4:27 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
compnerd added inline comments.Jul 25 2019, 4:41 PM
clang/lib/Driver/Types.cpp
113 ↗(On Diff #211981)

I think this is better written as:

static const clang::driver::types::ID kStaticLangageTypes[] = {
  TY_CUDA_DEVICE, TY_HIP_DEVICE, ...
};
return !llvm::contains(kStaticLangageTypes, Id);
plotfi updated this revision to Diff 211981.Jul 26 2019, 12:16 PM
plotfi marked an inline comment as done.

addressing @compnerd 's feedback

This revision is now accepted and ready to land.Jul 26 2019, 12:28 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 30 2019, 12:02 PM
plotfi updated this revision to Diff 212634.Jul 31 2019, 11:47 AM

trying to re-land, changing TY_ObjCXXHeader to TY_PP_ObjCXXHeader,