Page MenuHomePhabricator

[AArch64][GlobalISel] Select immediate modes for ADD when selecting G_GEP
ClosedPublic

Authored by paquette on Jul 24 2019, 3:42 PM.

Details

Summary

Before, we weren't able to select things like this for G_GEP:

add     x0, x8, #8

And instead we'd materialize the 8.

This teaches GISel to do that. It gives some considerable code size savings
on 252.eon-- about 4%!

Diff Detail

Repository
rL LLVM

Event Timeline

paquette created this revision.Jul 24 2019, 3:42 PM
aemerson accepted this revision.Jul 24 2019, 3:59 PM

Can you add a constant out of range immediate test too? LGTM otherwise.

This revision is now accepted and ready to land.Jul 24 2019, 3:59 PM
paquette updated this revision to Diff 211628.Jul 24 2019, 4:08 PM

updating test before committing

This revision was automatically updated to reflect the committed changes.