This is an archive of the discontinued LLVM Phabricator instance.

Differential D65136

[llvm-objdump] - Import the test/Object/X86/no-start-symbol.test test case and rewrite it to use YAML.
ClosedPublic

Authored by grimar on Jul 23 2019, 3:12 AM.

Details

Reviewers
jhenderson
MaskRay
Commits
rG7d79b552e36d: [llvm-objdump] - Import the test/Object/X86/no-start-symbol.test test case and…
rL366896: [llvm-objdump] - Import the test/Object/X86/no-start-symbol.test test case and…
Summary

This patch removes test/Object/X86/no-start-symbol.test (rewrites
it to use YAML and moves it to llvm-objdump tests folder).

(This test was initially introduced in rL239039, but now there
is no reason to keep the precompiled binary it seems).

Diff Detail

Event Timeline

grimar created this revision.Jul 23 2019, 3:12 AM
Herald added a subscriber: rupprecht. · View Herald TranscriptJul 23 2019, 3:12 AM
jhenderson accepted this revision.Jul 23 2019, 4:59 AM

LGTM.

This revision is now accepted and ready to land.Jul 23 2019, 4:59 AM
MaskRay accepted this revision.Jul 23 2019, 10:49 PM
Closed by commit rL366896: [llvm-objdump] - Import the test/Object/X86/no-start-symbol.test test case and… (authored by grimar). · Explain WhyJul 24 2019, 5:27 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 24 2019, 5:27 AM

Revision Contents

PathSize
test/
Object/
Inputs/
X86/
tools/
llvm-objdump/
X86/
28 lines

Diff 211269

test/Object/Inputs/no-start-symbol.elf-x86_64

  • This binary file was deleted.

test/Object/X86/no-start-symbol.test

  • This file was deleted.
RUN: llvm-objdump -d %p/../Inputs/no-start-symbol.elf-x86_64 | FileCheck %s
Test that we disassemble the start of the section.
CHECK: Disassembly of section .text:
CHECK-EMPTY:
CHECK-NEXT: .text:
CHECK-NEXT: 0: 90 nop
CHECK: foo:
CHECK-NEXT: 1: 90 nop

test/tools/llvm-objdump/X86/disassemble-no-symbol-at-section-start.test

  • This file was added.
## Test that we disassemble the start of the section even
## if there is no start symbol.
# RUN: yaml2obj %s -o %t
# RUN: llvm-objdump -d %t | FileCheck %s
# CHECK: Disassembly of section .text:
# CHECK-EMPTY:
# CHECK-NEXT: .text:
# CHECK-NEXT: 0: 90 nop
# CHECK: foo:
# CHECK-NEXT: 1: 90 nop
--- !ELF
FileHeader:
Class: ELFCLASS64
Data: ELFDATA2LSB
Type: ET_REL
Machine: EM_X86_64
Sections:
- Name: .text
Type: SHT_PROGBITS
Flags: [ SHF_ALLOC, SHF_EXECINSTR ]
Content: '9090'
Symbols:
- Name: foo
Section: .text
Value: 0x0000000000000001