Page MenuHomePhabricator

[ARM][LowOverheadLoops] Revert remaining pseudos
ClosedPublic

Authored by samparker on Jul 22 2019, 6:02 AM.

Details

Summary

ARMLowOverheadLoops would assert a failure if it did not find all the pseudo instructions that comprise the hardware loop. Instead of doing this, iterate through all the instructions of the function and revert any remaining pseudo instructions that haven't been converted.

Diff Detail

Repository
rL LLVM

Event Timeline

samparker created this revision.Jul 22 2019, 6:02 AM
dmgreen accepted this revision.Jul 22 2019, 6:43 AM

Looks good to me.

lib/Target/ARM/ARMLowOverheadLoops.cpp
103 ↗(On Diff #211068)

Maybe just
Changed |= RevertNonLoops(MF);
return Changed;

This revision is now accepted and ready to land.Jul 22 2019, 6:43 AM
Closed by commit rL366691: [ARM][LowOverheadLoops] Revert remaining pseudos (authored by sam_parker, committed by ). · Explain WhyJul 22 2019, 7:17 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 22 2019, 7:17 AM