Page MenuHomePhabricator

NFC: Region annotation intrnsics addition based on RFC from llvmpar
Needs ReviewPublic

Authored by xtian on Jul 18 2019, 4:00 PM.

Details

Reviewers
hfinkel
vadve
Summary

This is the 1st NFC patch for Region Annotation instrinsic addition

Diff Detail

Repository
rL LLVM

Event Timeline

xtian created this revision.Jul 18 2019, 4:00 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 18 2019, 4:00 PM
jdenny added a subscriber: jdenny.Jul 19 2019, 5:38 AM
neboat added a subscriber: neboat.Thu, Aug 1, 2:27 PM
neboat added inline comments.
llvm/include/llvm/IR/Intrinsics.td
965

In the LLVMPar RFC, we proposed that int_region_marker would return an i1. We needed that facility to use this intrinsic to model certain types of parallel control flow, e.g., Tapir.

xtian marked an inline comment as done.Thu, Aug 1, 2:33 PM

I will the change, do you want to make it i8, or int ?

llvm/include/llvm/IR/Intrinsics.td
965

Ok, I will make a change, i1 or int?

xtian added a comment.Thu, Aug 1, 2:34 PM

I would suggest we go with llvm_i32_ty.

Where's the latest RFC for this?

llvm/include/llvm/IR/Intrinsics.td
958–959

There is no RegionAnnotation.rst, not in trunk, not in this patch, not in parent differentials in stack,

xtian updated this revision to Diff 214210.Thu, Aug 8, 12:30 PM